Re: [PATCH v9 10/16] mm/mglru: Run aging when pages are rare outside the youngest gen

From: Kairui Song

Date: Sun Nov 15 2026 - 10:55:16 EST


On Sun, Nov 15, 2026 at 4:09 AM Barry Song (Xiaomi) <baohua@xxxxxxxxxx> wrote:
>
> From: Gaofei Lyu <lyugaofei@xxxxxxxxxx>
>
> Run aging when the total number of pages outside the youngest
> generation across both types falls below 1/MAX_NR_GENS of the number
> of pages in the youngest generation. For extreme swappiness values
> such as 1 and 200, also consider the balance of the corresponding
> type.
>
> This improves reclaim efficiency, especially at extreme swappiness
> values, while reducing system time.
>
> To avoid the overhead of aging, we only allow imbalance-based aging
> when the reclaim priority is low enough that we might reclaim the
> youngest generation.
>
> Signed-off-by: Gaofei Lyu <lyugaofei@xxxxxxxxxx>
> Co-developed-by: Barry Song (Xiaomi) <baohua@xxxxxxxxxx>
> Signed-off-by: Barry Song (Xiaomi) <baohua@xxxxxxxxxx>
> ---
> mm/vmscan.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 42 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0fef966b0a14..1450542d709c 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2743,6 +2743,8 @@ static bool should_clear_pmd_young(void)
> #define get_memcg_gen(seq) ((seq) % MEMCG_NR_GENS)
> #define get_memcg_bin(bin) ((bin) % MEMCG_NR_BINS)
>
> +#define AGING_PRIORITY (DEF_PRIORITY / 2)
> +
> static int get_swappiness(struct lruvec *lruvec, struct scan_control *sc)
> {
> struct mem_cgroup *memcg = lruvec_memcg(lruvec);
> @@ -4780,7 +4782,7 @@ static int scan_folios(unsigned long nr_to_scan, struct lruvec *lruvec,
> */
> if (sc->priority == DEF_PRIORITY)
> seq = lrugen->max_seq - MIN_NR_GENS;
> - else if (sc->priority > DEF_PRIORITY / 2)
> + else if (sc->priority > AGING_PRIORITY)
> seq = lrugen->max_seq - 1;
> else
> seq = lrugen->max_seq;
> @@ -5073,6 +5075,40 @@ static int evict_folios(unsigned long nr_to_scan, struct lruvec *lruvec,
> return scanned;
> }
>
> +static bool lru_gen_imbalanced(struct lruvec *lruvec, struct scan_control *sc,
> + int swappiness)
> +{
> + unsigned long youngest[ANON_AND_FILE] = {0}, old[ANON_AND_FILE] = {0};
> + struct lru_gen_folio *lrugen = &lruvec->lrugen;
> + DEFINE_MAX_SEQ(lruvec);
> + DEFINE_MIN_SEQ(lruvec);
> + int type;
> +
> + if (sc->priority > AGING_PRIORITY)
> + return false;
> +
> + /*
> + * Round up or down corner swappiness, to balance the heavy biased
> + * type better
> + */
> + if (swappiness == MIN_SWAPPINESS + 1)
> + swappiness = MIN_SWAPPINESS;
> + else if (swappiness == MAX_SWAPPINESS)
> + swappiness = MAX_SWAPPINESS + 1;
> +
> + for_each_evictable_type(type, swappiness) {
> + unsigned long seq;
> +
> + youngest[type] = lruvec_gen_size(lrugen, type, max_seq);
> + for (seq = min_seq[type]; seq < max_seq; seq++)
> + old[type] += lruvec_gen_size(lrugen, type, seq);
> + }

A little nit: with the rounding above, I think we don't need youngest
/ old as an array, just an accumulative value seems enough now? But
feel free to ignore this so we can avoid more update noise in this
series.

> +
> + /* the vast majority of pages sit in the youngest gen */
> + return youngest[LRU_GEN_ANON] + youngest[LRU_GEN_FILE] >
> + (old[LRU_GEN_ANON] + old[LRU_GEN_FILE]) * MAX_NR_GENS;
> +}
> +
> static bool should_run_aging(struct lruvec *lruvec, unsigned long max_seq,
> struct scan_control *sc, int swappiness)
> {
> @@ -5087,7 +5123,11 @@ static bool should_run_aging(struct lruvec *lruvec, unsigned long max_seq,
> return false;
>
> /* better to run aging even though eviction is still possible */
> - return evictable_min_seq(min_seq, swappiness) + MIN_NR_GENS == max_seq;
> + if (evictable_min_seq(min_seq, swappiness) + MIN_NR_GENS == max_seq)
> + return true;
> +
> + /* run aging when folios outside the youngest gen are rare */
> + return lru_gen_imbalanced(lruvec, sc, swappiness);
> }
>
> static void lru_gen_prepare_scan(struct lruvec *lruvec, struct scan_control *sc,
> --
> 2.39.3 (Apple Git-146)

Reviewed-by: Kairui Song <kasong@xxxxxxxxxxx>