Re: [PATCH 2/3] dt-bindings: spmi: Add SmartDV SPMI controller
From: VAMSHI GAJJELA
Date: Sun Nov 15 2026 - 12:14:27 EST
On Wed, Nov 4, 2026 at 7:44 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Tue, Nov 03, 2026 at 09:56:06AM +0530, vamshi gajjela wrote:
> > From: Vamshi Gajjela <vamshigajjela@xxxxxxxxxx>
> >
> > Document the device tree bindings for the SmartDV IP Solutions MIPI SPMI
> > master controller ("smartdv,spmi").
> >
> > This controller IP is integrated in Google Tensor SoCs starting with the
> > G5 generation (codename: laguna, canonically written as "lga"), so add
> > "google,lga-spmi" with a fallback to "smartdv,spmi".
> >
> > Signed-off-by: Vamshi Gajjela <vamshigajjela@xxxxxxxxxx>
> > ---
> > .../bindings/spmi/smartdv,spmi.yaml | 126 ++++++++++++++++++
> > MAINTAINERS | 6 +
> > 2 files changed, 132 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml b/Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml
> > new file mode 100644
> > index 000000000000..e0512e60d932
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spmi/smartdv,spmi.yaml
> > @@ -0,0 +1,126 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spmi/smartdv,spmi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SmartDV IP Solutions SPMI Controller
> > +
> > +maintainers:
> > + - Vamshi Gajjela <vamshigajjela@xxxxxxxxxx>
> > +
> > +description:
> > + SmartDV IP Solutions MIPI System Power Management Interface (SPMI) master
> > + controller supporting MIPI SPMI Specification versions 1.0 and 2.0.
> > +
> > +allOf:
> > + - $ref: spmi.yaml#
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - const: google,lga-spmi
> > + - const: smartdv,spmi
> > + - const: smartdv,spmi
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description:
> > + Core clock to the controller from which SPMI SCL is derived. Optional if
> > + the controller uses a free-running clock and clock-frequency is specified.
>
> Don't repeat constraints in free form text. Just create proper
> constraints.
>
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + clock-frequency:
> > + description:
> > + Input core clock frequency in Hz when the controller uses a free-running
> > + clock not described in clocks.
>
> Why clock would not be described in clocks? From where does it come?
Agreed. Even a free-running clock should be described through a clock
provider (e.g. fixed-clock) and referenced via clocks. On LGA the
controller has a clock and reset line, so in v2 I will drop
clock-frequency, keep only clocks and resets, and mark both as required
(removing the redundant prose from clocks).
>
> > +
> > + smartdv,master-arb-enable:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [0, 1]
> > + default: 0
> > + description:
> > + Enable master bus arbitration phase (0 = disable, 1 = enable).
> > +
> > + smartdv,master-id:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0
> > + maximum: 3
> > + default: 0
> > + description:
> > + Master ID for the controller on the SPMI bus.
>
> smartdv,bus-id, I guess
In MIPI SPMI this is the controller's arbitration ID (MID, 0..3) rather
than a bus index, used only in multi-master configurations. Since LGA
runs with arbitration disabled and none of the smartdv,* parameters vary
per board, I will drop this property (along with all other smartdv,*
properties) in v2.
>
> > +
> > + smartdv,spmi-version:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [0, 1]
> > + default: 0
> > + description:
> > + MIPI SPMI specification version used for transfers (0 for MIPI SPMI v1.0,
> > + 1 for MIPI SPMI v2.0).
>
> And why would that be board level configuration?
>
> > +
> > + smartdv,arb-retry-limit:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0
> > + maximum: 255
> > + default: 32
> > + description:
> > + Maximum number of times the master retries a command when losing bus
> > + arbitration.
> > +
> > + smartdv,prescaler:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0
> > + maximum: 255
> > + default: 0
> > + description:
> > + Clock divider value to generate SPMI SCL from the input core clock. Writing
> > + 1 divides the system clock by 2; more generally, a non-zero value n
> > + divides the system clock by 2 * n.
> > +
> > + smartdv,read-latency:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0
> > + maximum: 255
> > + default: 32
> > + description:
> > + Number of SPMI SCL clock cycles to pause during bus turnaround on read
> > + commands to allow the target device to fetch data.
> > +
> > + smartdv,arb-scl-delay:
>
> Except Conor's comments, some of the properties here should use proper
> units.
As replied to Conor, all smartdv,* parameters do not vary per board on
LGA. In v2 I will drop all smartdv,* properties and the generic
"smartdv,spmi" compatible, move the LGA controller configuration into
of_device_id match data keyed off "google,lga-spmi", rename the binding
to google,lga-spmi.yaml, and drop patch 1/3 (vendor-prefixes.yaml) since
no "smartdv" prefix remains in DT.
Thanks,
Vamshi Gajjela