Re: [PATCH 3/3] spmi: Add SmartDV SPMI controller driver
From: VAMSHI GAJJELA
Date: Sun Nov 15 2026 - 12:23:32 EST
On Fri, Nov 6, 2026 at 10:28 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> Hello,
>
> On Tue, Nov 03, 2026 at 09:56:07AM +0530, vamshi gajjela wrote:
> > +#include <linux/mod_devicetable.h>
> > [...]
> > +#include <linux/platform_device.h>
>
> Please don't use <linux/mod_devicetable.h>. <linux/platform_device.h> is
> good enough to provide of_device_id already. If you insist on full iwyu,
> please use <linux/device-id/of.h> instead.
>
> > [...]
> > +static const struct of_device_id smartdv_spmi_of_match[] = {
> > + { .compatible = "smartdv,spmi" },
> > + {}
>
> { } please
Will drop <linux/mod_devicetable.h> and update the sentinel to { } in v2.
Thanks,
Vamshi Gajjela.