Re: [PATCH v7 1/7] dt-bindings: net: amlogic,meson-dwmac: list the compatible combinations

From: Martin Blumenstingl

Date: Sun Nov 15 2026 - 12:41:07 EST


On Fri, Nov 13, 2026 at 1:18 PM Lucas Tanure <tanure@xxxxxxxxx> wrote:
>
> The compatible property only checks that the first entry is an Amlogic
> name and that "snps,dwmac" or "snps,dwmac-3.70a" appears somewhere in
> the list. It cannot express which fallbacks each SoC takes, so a SoC
> built on a different Synopsys core cannot be added without loosening
> the check for every other one.
>
> List the combinations the device trees use: Meson6 falls back to
> "snps,dwmac" alone, the others also name the 3.70a core. The Meson8m2
> reports a 3.70a core too, so it joins that list; its dtsi gets the
> missing entry in a separate patch. The example used a two-entry form no
> device tree has, so give it the Meson GXBB combination.
>
> Suggested-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>