[PATCH net-next v2] net: phy: et1011c: don't write an error code to the config register
From: Elias Pukari
Date: Sun Nov 15 2026 - 13:08:17 EST
phy_read() can return a negative error code. Use an int and check
both reads before using their results.
Found with LLM help; fake-MDIO KUnit error-injection tests passed
(6/6, KASAN). No hardware testing.
Signed-off-by: Elias Pukari <elias.pukari@xxxxxxxxx>
---
v2: Drop Fixes and shorten the commit message; no code changes.
v1: https://lore.kernel.org/netdev/20261113221917.3542509-1-elias.pukari@xxxxxxxxx/
drivers/net/phy/et1011c.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/et1011c.c b/drivers/net/phy/et1011c.c
index 6cd8d7758..603fe5a1e 100644
--- a/drivers/net/phy/et1011c.c
+++ b/drivers/net/phy/et1011c.c
@@ -62,16 +62,22 @@ static int et1011c_read_status(struct phy_device *phydev)
{
static int speed;
int ret;
- u32 val;
+ int val;
ret = genphy_read_status(phydev);
if (speed != phydev->speed) {
speed = phydev->speed;
val = phy_read(phydev, ET1011C_STATUS_REG);
+ if (val < 0)
+ return val;
+
if ((val & ET1011C_SPEED_MASK) ==
ET1011C_GIGABIT_SPEED) {
val = phy_read(phydev, ET1011C_CONFIG_REG);
+ if (val < 0)
+ return val;
+
val &= ~ET1011C_TX_FIFO_MASK;
phy_write(phydev, ET1011C_CONFIG_REG, val |
ET1011C_GMII_INTERFACE |
base-commit: d1f4b7c6b997c29de67ad7178ababac2328cb1b4