Re: [PATCH] usb: uas: expose US_FL_NO_ATA_1X in sysfs as deny_ata_passthrough

From: Mateusz Jończyk

Date: Sun Nov 15 2026 - 13:26:55 EST


W dniu 15.11.2026 o 16:52, Alan Stern pisze:
On Sun, Nov 15, 2026 at 01:40:46PM +0100, Mateusz Jończyk wrote:
The uas driver blocks access to ATA passthrough commands for some
devices it considers buggy (via the US_FL_NO_ATA_1X flag in
unusual_uas.h and uas_detect.h). However, it does not expose any
meaningful information whether the command was blocked by the driver or
is genuinly not supported by the hardware. This creates a problem for
the smartmontools program and makes it difficult for it to provide a
useful error message (with instructions to disable UAS on the drive to
get SMART readings).

So, expose the information in sysfs as deny_ata_passthrough. Other
quirks may be added in the future if there is any demand.

Link: https://www.smartmontools.org/wiki/SAT-with-UAS-Linux
Signed-off-by: Mateusz Jończyk <mat.jonczyk@xxxxx>
Why was this change made to uas but not to usb-storage? Was it because
some devices can handle ATA passthrough commands over the Bulk-Only
transport but not over the UAS transport? Note that the
US_FL_NO_ATA_1X flag applies to both transports.

Alan Stern

There are only very few devices that cannot handle ATA passthrough commands
over the Bulk-Only transfer (and with them it's impossible to get ATA
passthrough by disabling UAS). But that's a fair point, will fix it in v2.

Considering the US_FL_NO_ATA_1X flag:

- I suspect that many more devices would accept the ATA passthrough commands in
  UAS mode if these would be issued in isolation (if uas_queuecommand_lck()
  would stop all other transfers while doing them). After all, Windows
  apparently does not carry such quirks for modern devices. I do not have the
  hardware to test, though.

- Since 2017, it is set unequivocally for all Seagate drives, even though most
  likely modern drives / firmware versions do not need it. I do not see a way
  out, though.

Greetings,

Mateusz