Re: [PATCH v4] mm/cma: simplify cma_declare_contiguous_multi()

From: Andrew Morton

Date: Sun Nov 15 2026 - 13:59:53 EST


On Sun, 15 Nov 2026 08:27:03 +0200 "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx> wrote:

> When cma_declare_contiguous_multi() cannot allocate a CMA area as a
> single range, it falls back to collecting a list of up to CMA_MAX_RANGES
> largest free ranges above 4G, reserves them in memblock and adds them to
> cma->ranges.
>
> The list and subsequently cma->ranges are supposed to be sorted in the
> order of base addresses of the "allocated" ranges.
>
> This implementation has two bugs:
>
> * The allocation may fail even when there is enough free memory because
> list_insert_sorted() sorts the list in the wrong order.
>
> When the list is full, the largest range is evicted rather than the
> smallest, the final list is not sorted by address, and the smallest
> ranges are used first.
>
> * the function may report success while it reserved less memory than
> requested because sizesum accounts for ranges that were skipped.
>
> And overall it is a lot of list management and open coded range
> selection for no real gain.
>
> Replace the current code with a loop that finds the largest free range
> above 4G, reserves as much of it as needed and repeats until the entire
> area is reserved or CMA_MAX_RANGES ranges are used.
>
> After successful alocation sort the cma->ranges by their base address.
>
> The new code scans free memory once for every range rather than once
> for all ranges, so it is slightly slower, but it is way simpler and more
> robust.

Updated, thanks.

> - silence smatch warning about SZ_4G on 32 bits
> - fix a type in a comment

delta:

--- a/mm/cma.c~mm-cma-simplify-cma_declare_contiguous_multi-v4
+++ a/mm/cma.c
@@ -485,12 +485,12 @@ static phys_addr_t __init cma_find_free_
phys_addr_t max = 0;
u64 i;

- /* no point searching if the system can't addres above 4G */
+ /* no point searching if the system can't address above 4G */
if (!IS_ENABLED(CONFIG_PHYS_ADDR_T_64BIT))
return 0;

for_each_free_mem_range(i, nid, MEMBLOCK_NONE, &start, &end, NULL) {
- if (start < SZ_4G)
+ if (!upper_32_bits(start))
continue;

start = ALIGN(start, align);
_