Re: [PATCH net-next v1 10/11] eth: fbnic: Support RX buffers it cannot split
From: Björn Töpel
Date: Sun Nov 15 2026 - 14:12:47 EST
netdev-bot+sashiko@xxxxxxxxxx writes:
[...]
> Wouldn't the restarted queue keep the old EN_HDR_SPLIT, which no longer
> matches the MAX_HDR, PAYLD_OFF and PAYLD_PG_CL values in CTL1? Nothing
> corrects it until the next restart of that queue.
Pre-existing for the drop mode, and the per-queue bits make it worse. I
have a net fix that serializes link up and queue start with a lock.
[...]
> Should both callers require that the completion starts the buffer and
> also closes it, i.e. a zero offset and PAGE_FIN set? Passing the rcd
> into fbnic_bd_one_desc() and doing both checks there might keep the
> header and payload paths from drifting apart again.
v2 drops these checks instead. With MAX_HDR, PAYLD_OFF and PAYLD_PG_CL
as programmed, the device closes a whole buffer after one descriptor,
and fbnic trusts its completion ring everywhere else.
Björn