[PATCH 2/7] platform/x86: lenovo-ymc: Serialize WMI event handling
From: Rong Zhang
Date: Sun Nov 15 2026 - 14:28:44 EST
WMI events may arrive in parallel, causing race conditions, e.g.,
CPU1 CPU2
query: posture A
query: posture B
input report B
input report A
trigger EC with B
trigger EC with A
Fix it by serializing lenovo_ymc_notify() with a mutex.
Fixes: e82882cdd241 ("platform/x86: Add driver for Yoga Tablet Mode switch")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Rong Zhang <i@xxxxxxxx>
---
drivers/platform/x86/lenovo/ymc.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/lenovo/ymc.c b/drivers/platform/x86/lenovo/ymc.c
index 70f3ae20d3e3..eba22600161e 100644
--- a/drivers/platform/x86/lenovo/ymc.c
+++ b/drivers/platform/x86/lenovo/ymc.c
@@ -10,9 +10,11 @@
#include <linux/acpi.h>
#include <linux/bitfield.h>
#include <linux/bits.h>
+#include <linux/cleanup.h>
#include <linux/dmi.h>
#include <linux/input.h>
#include <linux/input/sparse-keymap.h>
+#include <linux/mutex.h>
#include <linux/wmi.h>
#include "ideapad-laptop.h"
@@ -60,6 +62,7 @@ static const struct dmi_system_id allowed_chasis_types_dmi_table[] = {
struct lenovo_ymc_private {
struct input_dev *input_dev;
+ struct mutex mutex; /* Protects event handling. */
};
static const struct key_entry lenovo_ymc_keymap[] = {
@@ -82,6 +85,8 @@ static void lenovo_ymc_notify(struct wmi_device *wdev, union acpi_object *data)
acpi_status status;
int code;
+ guard(mutex)(&priv->mutex);
+
status = wmi_evaluate_method(LENOVO_YMC_QUERY_GUID,
LENOVO_YMC_QUERY_INSTANCE,
LENOVO_YMC_QUERY_METHOD,
@@ -137,6 +142,10 @@ static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx)
if (!input_dev)
return -ENOMEM;
+ err = devm_mutex_init(&wdev->dev, &priv->mutex);
+ if (err)
+ return err;
+
input_dev->name = "Lenovo Yoga Tablet Mode Control switch";
input_dev->phys = LENOVO_YMC_EVENT_GUID "/input0";
input_dev->id.bustype = BUS_HOST;
--
2.55.0