[PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: fix out-of-bounds access in cck_pd_set
From: Zeshan Ahmed Nobin
Date: Sun Nov 15 2026 - 15:20:46 EST
rtw8822c_phy_cck_pd_set() reads the bandwidth from a 2-bit register
field and uses it as the first index into dm_info->cck_pd_lv[], which
only has entries for 20 and 40 MHz.
When the chip stops responding on the PCIe bus, register reads return
all ones and bw becomes 3. The function then reads cck_pd_lv[3][nrx],
past the end of the array. If that byte differs from new_lvl, it calls
rtw8822c_phy_cck_pd_set_reg(), which rejects bw with WARN_ON(), and
then writes new_lvl to cck_pd_lv[3][nrx] anyway. UBSAN reports the
first of these accesses as:
UBSAN: array-index-out-of-bounds in .../rtw88/rtw8822c.c:4407:21
index 3 is out of range for type 'u8 [2][4]'
Workqueue: phy0 rtw_watch_dog_work [rtw88_core]
Call Trace:
<TASK>
__ubsan_handle_out_of_bounds+0xdd/0x120
rtw8822c_phy_cck_pd_set+0x33c/0x510 [rtw88_8822c]
rtw_phy_dynamic_mechanism+0x310/0x330 [rtw88_core]
rtw_watch_dog_work+0x217/0x330 [rtw88_core]
The driver doesn't need to read the bandwidth from the chip:
rtw_set_channel() stores it in rtwdev->hal.current_band_width and
programs the same value into the chip. Use the stored value. CCK PD
only runs on 2.4 GHz, where the bandwidth is 20 or 40 MHz, so the
stored value is always a valid index.
On PCIe, a chip that stops responding still returns nrx = 3; the next
patch handles nrx values without CCK PD registers.
The fix and this message were drafted with an AI coding assistant
(Claude Opus 5.5 by Anthropic), then reviewed and tested by the
submitter.
Fixes: 479c4ee931a6 ("rtw88: add dynamic cck pd mechanism")
Cc: stable@xxxxxxxxxxxxxxx
Suggested-by: Luka Gejak <luka.gejak@xxxxxxxxx>
Signed-off-by: Zeshan Ahmed Nobin <zeshanahmednobin@xxxxxxxxx>
---
Notes:
Testing, on an RTL8822CE in an ASUS TUF Gaming A15 (FA506IU) whose chip
intermittently stops responding on the PCIe bus:
- Without this patch, on Ubuntu's 6.8.0-147 and 7.0.0-42 kernels, 22 of
the 23 boots in which the chip failed while the driver was running
logged three UBSAN reports for the reads, the WARN_ON() and one report
for the write; the other logged neither. Boots without a failure
logged neither. The trace above is from 7.0.0-42, whose line numbers
are three lower than mainline here.
- With both patches on 6.8.0-147, whose CCK PD and channel code is the
same as rtw-next's, a debug-only counter compared hal's bandwidth with
bits 3:2 of 0x9b0 at every call. On a 40 MHz connection on 2.4 GHz,
they matched at all 1389 calls, across 20 hardware scans and 3
associations.
- In the same setup, the chip failed in two boots. The function then
ran 13 and 15 times while the chip read back all ones (0x9b0 gave
0xffffffff). Neither boot logged a UBSAN report or a warning from
rtw88 after the failure.
- Build-tested on rtw-next (04c998418722) with W=1: no warnings.
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index 09315d23e2c4..df7df76785e4 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -4404,7 +4404,7 @@ static void rtw8822c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
u8 nrx, bw;
nrx = (u8)rtw_read32_mask(rtwdev, 0x1a2c, 0x60000);
- bw = (u8)rtw_read32_mask(rtwdev, 0x9b0, 0xc);
+ bw = rtwdev->hal.current_band_width;
rtw_dbg(rtwdev, RTW_DBG_PHY, "lv: (%d) -> (%d) bw=%d nr=%d cck_fa_avg=%d\n",
dm_info->cck_pd_lv[bw][nrx], new_lvl, bw, nrx,
--
2.43.0