Re: [PATCH] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add S4 support

From: Martin Blumenstingl

Date: Sun Nov 15 2026 - 15:35:18 EST


On Fri, Nov 6, 2026 at 11:46 AM
<christian.koever-draxl@xxxxxxxxxxxxxxxxxx> wrote:
>
> From: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
>
> The S4 USB glue is the G12A one, but it fronts an xHCI host controller
> instead of a DWC3 core, with two USB2 PHYs and no USB3 PHY. Add an S4
> compatible with the G12A one as fallback, and allow a generic xHCI
> child node.
Krzysztof, I have have a question regarding the last sentence:

[...]
> oneOf:
> - $ref: dwc2.yaml#
> - $ref: snps,dwc3.yaml#
> + - $ref: generic-xhci.yaml#
Does this mean we need to the allowed child-nodes to the compatible
string (so only S4 allows generic-xhci and G12A only allows dwc2/dwc3
but not generic-xhci)?