Re: [PATCH] PM / devfreq: tegra30: Remove redundant dev_err()
From: Chanwoo Choi
Date: Sun Nov 15 2026 - 17:57:08 EST
On 7/13/2026 10:13 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
> drivers/devfreq/tegra30-devfreq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 401aac6a9f07..d149694becd9 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -880,10 +880,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> err = devm_request_threaded_irq(&pdev->dev, tegra->irq, NULL,
> actmon_thread_isr, IRQF_ONESHOT,
> "tegra-devfreq", tegra);
> - if (err) {
> - dev_err(&pdev->dev, "Interrupt request failed: %d\n", err);
> + if (err)
> return err;
> - }
>
> err = devm_pm_opp_set_config(&pdev->dev, &config);
> if (err) {
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Principal Engineer, Samsung Electronics