Re: [PATCH v2 0/4] Unsorted tpm2-sessions improvements
From: Jarkko Sakkinen
Date: Sun Nov 15 2026 - 18:52:31 EST
On Mon, Nov 16, 2026 at 01:43:45AM +0200, Jarkko Sakkinen wrote:
> On Mon, Nov 16, 2026 at 01:31:52AM +0200, Jarkko Sakkinen wrote:
> > v2:
> >
> > - Based on Sashiko feedback I changed "offset += tpm_buf_read_u16()" into
> > "rc = tpm_buf_read_u16(...)" and "offset += rc". I'm convinced that this
> > was necessary but since it does not have a cost, at least this should
> > mute Sashiko.
>
> No further Sashiko complains.
tpm_buf_read*() really should update the offset on success, and be
fallible calls. Overflow-flag, and eventual failure makes more
sense when building commands.
Br, Jarkko