Re: [PATCH] media: qcom: iris: fix PAS ID passed to set_remote_state
From: bod
Date: Sun Nov 15 2026 - 19:24:51 EST
On 2026-10-20 22:45 +0200, Jorge Ramirez-Ortiz wrote:
> A PAS ID of 0 does not identify the iris peripheral, so the
> remote-state update never reached it. Pass IRIS_PAS_ID, as every
> other PAS call in this file does.
>
> Fixes: bb8a95aa038e ("media: iris: implement power management")
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/qcom/iris/iris_firmware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c
> index 21cdf1c39835..6ff5eefff391 100644
> --- a/drivers/media/platform/qcom/iris/iris_firmware.c
> +++ b/drivers/media/platform/qcom/iris/iris_firmware.c
> @@ -195,5 +195,5 @@ int iris_fw_unload(struct iris_core *core)
>
> int iris_set_hw_state(struct iris_core *core, bool resume)
> {
> - return qcom_pas_set_remote_state(resume, 0);
> + return qcom_pas_set_remote_state(resume, IRIS_PAS_ID);
> }
> --
> 2.54.0
>
>
Reviewed-by: Bryan O'Donoghue <bod@xxxxxxxxxx>
---
bod