Re: [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status
From: Hangbin Liu
Date: Sun Nov 15 2026 - 19:57:18 EST
On Mon, Nov 16, 2026 at 12:45:48AM +0000, Tianyi Gao wrote:
> On Sun, 15 Nov 2026 22:47:02 +0100 Omokefe Emmanuel Onanaroghene wrote:
> > chk_channels() reports mismatches with a "fail" line but never sets
> > ret, so the script exits 0 even when channel counts are wrong.
>
> I found three more checks in the same file with the same problem:
>
> bad setting: XDP with RX nr less than TX
> bad setting: reducing RX nr below peer TX with XDP set
> bad setting: increasing peer TX nr above RX with XDP set
>
> Maybe it is worth fixing them all at once?
+1
>
> Tested-by: Tianyi Gao <tianyi@xxxxxxxxxxxxxx>
>
Hangbin