[PATCH 03/35] iio: chemical: ens160: use default_trigger

From: Jonathan Cameron

Date: Sun Nov 15 2026 - 20:49:29 EST


From: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>

Set indio_dev->default_trigger rather than taking a reference to the
trigger in probe(). The IIO core now takes the reference during
iio_device_register().

Previously the reference was taken before devm_iio_triggered_buffer_setup()
set INDIO_BUFFER_TRIGGERED, so a failure in that call leaked the trigger
reference as iio_dev_release() only drops it for devices with triggered
modes.

As indio_dev->trig is no longer set during probe(), pass the local trigger
pointer to devm_request_irq().

Fixes: 0fc26596b4b3 ("iio: chemical: ens160: add triggered buffer support")
Signed-off-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>

---
Technically a fix but only for a leak on an error path and backporting
this plus the infrastructure probably doesn't mkae sense.
---
drivers/iio/chemical/ens160_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/chemical/ens160_core.c b/drivers/iio/chemical/ens160_core.c
index 5e2b15463c99..7325f22ddf26 100644
--- a/drivers/iio/chemical/ens160_core.c
+++ b/drivers/iio/chemical/ens160_core.c
@@ -309,11 +309,10 @@ static int ens160_setup_trigger(struct iio_dev *indio_dev, int irq)
if (ret)
return ret;

- indio_dev->trig = iio_trigger_get(trig);
+ indio_dev->default_trigger = trig;

ret = devm_request_irq(dev, irq, iio_trigger_generic_data_rdy_poll,
- IRQF_NO_THREAD, indio_dev->name,
- indio_dev->trig);
+ IRQF_NO_THREAD, indio_dev->name, trig);
if (ret)
return ret;

--
2.56.1