[PATCH] cleanup-mm-mglru-Run-aging-when-pages-are-rare-outside-the-youngest-gen

From: Barry Song (Xiaomi)

Date: Sun Nov 15 2026 - 22:48:44 EST


As suggested by Kairui[1], we don't need youngest and old as
array. just an accumulative value should be enough.

No functional change.

[1] https://lore.kernel.org/linux-mm/CAMgjq7C_cH75JrYs8=P5LbxnDjDD6bqeqsCidOPa=r8Z+42sCQ@xxxxxxxxxxxxxx/

Suggested-by: Kairui Song <ryncsn@xxxxxxxxx>
Signed-off-by: Barry Song (Xiaomi) <baohua@xxxxxxxxxx>
---
mm/vmscan.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 7acc9acad985..b97dc3103b25 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -5086,8 +5086,8 @@ static int evict_folios(unsigned long nr_to_scan, struct lruvec *lruvec,
static bool lru_gen_imbalanced(struct lruvec *lruvec, struct scan_control *sc,
int swappiness)
{
- unsigned long youngest[ANON_AND_FILE] = {0}, old[ANON_AND_FILE] = {0};
struct lru_gen_folio *lrugen = &lruvec->lrugen;
+ unsigned long youngest = 0, old = 0;
DEFINE_MAX_SEQ(lruvec);
DEFINE_MIN_SEQ(lruvec);
int type;
@@ -5107,14 +5107,13 @@ static bool lru_gen_imbalanced(struct lruvec *lruvec, struct scan_control *sc,
for_each_evictable_type(type, swappiness) {
unsigned long seq;

- youngest[type] = lruvec_gen_size(lrugen, type, max_seq, sc->reclaim_idx + 1);
+ youngest += lruvec_gen_size(lrugen, type, max_seq, sc->reclaim_idx + 1);
for (seq = min_seq[type]; seq < max_seq; seq++)
- old[type] += lruvec_gen_size(lrugen, type, seq, sc->reclaim_idx + 1);
+ old += lruvec_gen_size(lrugen, type, seq, sc->reclaim_idx + 1);
}

/* the vast majority of pages sit in the youngest gen */
- return youngest[LRU_GEN_ANON] + youngest[LRU_GEN_FILE] >
- (old[LRU_GEN_ANON] + old[LRU_GEN_FILE]) * MAX_NR_GENS;
+ return youngest > old * MAX_NR_GENS;
}

static bool should_run_aging(struct lruvec *lruvec, unsigned long max_seq,
--
2.39.3 (Apple Git-146)

> > +       return youngest[LRU_GEN_ANON] + youngest[LRU_GEN_FILE] >
> > +              (old[LRU_GEN_ANON] + old[LRU_GEN_FILE]) * MAX_NR_GENS;

>
> Reviewed-by: Kairui Song <kasong@xxxxxxxxxxx>

Thanks!