Re: [PATCH v4 05/19] kho: Add feature header for fine-grained ABI compatibility

From: Chris Down

Date: Sun Nov 15 2026 - 23:34:36 EST


Hi Tarun,

tarunsahu@xxxxxxxxxx writes:
Techinically this is just for readability.

WDYT?

It doesn't help readability in the generated docs, though. kernel-doc
splits the parameter list on the comma inside the macro, so
kho_preserve_vmalloc() comes out as

int kho_preserve_vmalloc (void *ptr, DECLARE_KHO_SER_HDR(kho_vmalloc# *fhdr))

and the struct memfd_luo_ser and struct luo_session_ser definitions in the
ABI docs end up with a member like

DECLARE_KHO_SER_HDR(kho_vmalloc folios_fhdr;

I'd go with Pasha's suggestion and use struct kho_ser_hdr directly. The
pointer can then say which payload follows it with a comment.

Chris