Re: [PATCH net-next v5 2/3] ethtool: add a PHY receive byte total
From: Andrew Lunn
Date: Sun Nov 15 2026 - 23:40:16 EST
On Sun, Nov 15, 2026 at 09:12:35PM -0700, James Hilliard wrote:
> On Sun, Nov 15, 2026 at 8:25 AM Andrew Lunn <andrew@xxxxxxx> wrote:
> >
> > On Sun, Nov 15, 2026 at 12:45:46AM -0700, James Hilliard wrote:
> >
> > > The generic PHY receive-byte counter describes successfully received
> > > traffic. Some PHYs instead count bytes in all received frames,
> > > including frames with errors.
>
> That restriction comes from the current kernel-doc definition of
> ethtool_phy_stats.rx_bytes: "Total successfully received bytes".
Yes, i found this.
> Should we instead clarify the existing rx_bytes definition to include
> errored traffic and use it for ACx00, dropping rx_bytes_total? That
> would leave the existing packet counters unchanged.
What do you mean by errored traffic?
Think about it.
If you don't have a MAC, you don't have FCS.
Andrew