Re: [PATCH v19 08/11] tracing/wprobe: Add set_wprobe and clear_wprobe event triggers

From: Masami Hiramatsu (Google)

Date: Sun Nov 15 2026 - 23:43:53 EST


On Sat, 3 Oct 2026 16:53:45 +0900, Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
> --- a/kernel/trace/trace_wprobe.c
> +++ b/kernel/trace/trace_wprobe.c
> @@ -767,9 +928,632 @@ static int trace_wprobe_show(struct seq_file *m, struct dyn_event *ev)
> + * mode so that if the user did not explicitly enable this
> + * event, __ftrace_event_enable_disable() unregisters it.
> + */
> + set_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &wprobe_data->file->flags);

It seems I should not touch this, because when a wprobe has set_wprobe and
clear_wprobe triggers, and remove clear_wprobe trigger after hitting
set_wprobe trigger, this unconditionally soft disables it.


> + /* Remove the SOFT_MODE flag */
> + trace_event_enable_disable(wprobe_data->file, 0, 1);
> + trace_event_put_ref(wprobe_data->file->event_call);

`trace_event_put_ref()` is called here before `trigger_data_free(data)`
schedules RCU/tracepoint synchronization via `trigger_kthread`. When
`wprobe_trigger_free()` is called from `clear_event_triggers()` (which does
not call `tracepoint_synchronize_unregister()` synchronously), dropping the
target event reference here allows `wprobe_data->tw` to be freed while an
in-flight tracepoint is still executing `wprobe_trigger()`.
This put-ref should be done in data->private_data_free().

Thanks,
--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>