Re: [PATCH] iomap: don't update i_size of block devices on buffered write

From: Christoph Hellwig

Date: Mon Nov 16 2026 - 01:02:08 EST


On Fri, Nov 13, 2026 at 07:02:17AM -0800, Breno Leitao wrote:
> - if (pos + written > old_size &&
> + if (pos + written > old_size && !S_ISBLK(iter->inode->i_mode) &&
> !(iter->iomap.flags & IOMAP_F_FSVERITY)) {
> i_size_write(iter->inode, pos + written);
> iter->iomap.flags |= IOMAP_F_SIZE_CHANGED;
> }
> __iomap_put_folio(iter, write_ops, written, folio);
>
> - if (old_size < pos && !(iter->iomap.flags & IOMAP_F_FSVERITY))
> + if (old_size < pos && !S_ISBLK(iter->inode->i_mode) &&
> + !(iter->iomap.flags & IOMAP_F_FSVERITY))

Please add a function scope "update_isize" variable instead of
duplicating these checks. Otherwise looks good.