Re: [PATCH net v9 3/4] net: hsr: segment GSO before per-frame forwarding
From: Xin Xie
Date: Mon Nov 16 2026 - 04:07:26 EST
On 15/11/2026 22:41, Sebastian Andrzej Siewior wrote:
> Should you repost:
>
> diff --git a/net/hsr/hsr_forward.c b/net/hsr/hsr_forward.c
> index 9aefc5f0249f6..5e49f2bb9e39b 100644
> --- a/net/hsr/hsr_forward.c
> +++ b/net/hsr/hsr_forward.c
> @@ -940,11 +940,9 @@ void hsr_forward_input(struct sk_buff *skb, struct hsr_port *port)
> goto drop;
>
> consume_skb(skb);
> - while (segs) {
> - next = segs->next;
> - segs->next = NULL;
> + skb_list_walk_safe(segs, segs, next) {
> + skb_mark_not_on_list(segs);
> hsr_forward_frame(segs, port);
> - segs = next;
> }
> return;
>
>
> Sebastian
Thanks for the review. I will switch the loop to skb_list_walk_safe()
and skb_mark_not_on_list() if the series needs a repost.
--
Xin