Re: [PATCH 23/35] iio: common: st_sensors: use default_trigger
From: Linus Walleij
Date: Mon Nov 16 2026 - 05:12:59 EST
On Mon, Nov 16, 2026 at 2:50 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> From: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
>
> Set indio_dev->default_trigger rather than taking a reference to the
> trigger in st_sensors_allocate_trigger(). The IIO core now takes the
> reference during iio_device_register(), so it is not leaked if probe()
> fails after the trigger is set up.
>
> All users (st_accel, st_gyro, st_magn and st_pressure) allocate the
> triggered buffer and trigger before calling devm_iio_device_register()
> and do not access indio_dev->trig before that point. The interrupt
> handlers are passed the trigger directly.
>
> The ordering is such in here that their is no leak today, but in general
> this change will make things less fragile going forwards.
>
> Signed-off-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
Yours,
Linus Walleij