Re: [PATCH net-next 1/2] net: sgi: ioc3-eth: apply the DMA attributes only to 64-bit addresses

From: Imre Kaloz

Date: Mon Nov 16 2026 - 05:42:41 EST


> Can the code currently in the tree ever reach this branch?

No. On IP27 and IP30 every IOC3 DMA address has a nonzero target
widget in bits 63:60. The branch is for the IP35 series, where an
IOC3 behind an XBridge or PIC uses the 32-bit window. v2 says so in
the commit message:

https://lore.kernel.org/all/20261116102115.27574-1-kaloz@xxxxxxxxxx/

> Does the window path rely on platform code setting the D32 bits in
> b_device for the IOC3 slot?

It does, and nothing sets them today. On a Fuel both XBridges leave
PREF, PRECISE, COH and BARRIER clear in every b_device register,
including the IOC3 slot (0x180010f8). That belongs to the bridge code
in the IP35 series, which will set the attributes for slots that use
the window. ioc3-eth itself needs no change for it.

> Should the ERBAR value be decided from the RX descriptor ring
> address?

The IP35 series picks the window per device, not per address: an IOC3
behind an XBridge or PIC gets a 32-bit bus_dma_limit and SWIOTLB
bounces anything above it. The ring and every buffer of one IOC3
therefore use the same form.


Thanks,
Imre