Re: [PATCH v2 12/19] dt-bindings: cache: andestech: update schema for generic LLC support

From: Krzysztof Kozlowski

Date: Mon Nov 16 2026 - 07:06:05 EST


On Fri, Nov 13, 2026 at 02:05:29PM +0000, Conor Dooley wrote:
> On Fri, Nov 13, 2026 at 03:11:36PM +0800, Mina Hui-Min Chou wrote:
> > The last level cache controller of Andes cores is not specific to
> > AX45MP. Other Andes cores, such as the A27L2, use the same controller
> > with the same register interface, but the binding only accepts
> > andestech,ax45mp-cache. Add andestech,llcache for them, and describe
> > the binding as an Andes last level cache rather than an AX45MP L2
> > cache.
> >
> > The cache-level, cache-sets and cache-size constraints describe the
> > AX45MP L2 cache, so apply them to andestech,ax45mp-cache only. The LLC
> > of other Andes cores can be level 3 and have other geometries, so
> > allow cache-level 3 and require cache-sets only for AX45MP. Match
> > renesas,r9a07g043f-ax45mp-cache explicitly instead of through the else
> > branch, which would otherwise also apply to andestech,llcache.
> >
> > Also add an example for andestech,llcache, and add myself as a
> > maintainer of the binding.
> >
> > Signed-off-by: Mina Hui-Min Chou <minachou@xxxxxxxxxxxxx>
> > ---
> > .../cache/andestech,ax45mp-cache.yaml | 71 ++++++++++++++-----
> > 1 file changed, 54 insertions(+), 17 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml b/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
> > index b135ffa4ab6b..da9688cc95f7 100644
> > --- a/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
> > +++ b/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
> > @@ -5,14 +5,15 @@
> > $id: http://devicetree.org/schemas/cache/andestech,ax45mp-cache.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > -title: Andestech AX45MP L2 Cache Controller
> > +title: Andestech Last Level Cache Controller
> >
> > maintainers:
> > - Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > + - Mina Hui-Min Chou <minachou@xxxxxxxxxxxxx>
> >
> > description:
> > - A level-2 cache (L2C) is used to improve the system performance by providing
> > - a large amount of cache line entries and reasonable access delays. The L2C
> > + A last level cache (LLC) is used to improve the system performance by providing
> > + a large amount of cache line entries and reasonable access delays. The LLC
> > is shared between cores, and a non-inclusive non-exclusive policy is used.
> >
> > select:
> > @@ -21,18 +22,23 @@ select:
> > contains:
> > enum:
> > - andestech,ax45mp-cache
> > + - andestech,llcache
> >
> > required:
> > - compatible
> >
> > properties:
> > compatible:
> > - items:
> > - - enum:
> > - - andestech,qilai-ax45mp-cache
> > - - renesas,r9a07g043f-ax45mp-cache
> > - - const: andestech,ax45mp-cache
> > - - const: cache
> > + oneOf:
> > + - items:
> > + - enum:
> > + - andestech,qilai-ax45mp-cache
> > + - renesas,r9a07g043f-ax45mp-cache
> > + - const: andestech,ax45mp-cache
> > + - const: cache

Illogical split of patches. If this was to stay, then THIS commit is the
reason to rename so rename would happen here, not in some time in the
future. Same for everything you do.

Organize your patches correctly, not doing things half-baked... but
anyway do not rename files just because you added one compatible.


> > + - items:
> > + - const: andestech,llcache
> > + - const: cache
>
> Device specific compatibles are mandatory. I would accept this patch
> with a
> - not: {}
> description: Need a SoC specific compatible
> like the safexcel eip binding.

But why all others cannot use ax45mp as fallback? Is this really a
generic block among multiple generations of SoCs?

What sort of arguments from contributors are to support that?


>
> pw-bot: changes-requested
>
> Thanks,
> Conor.
>
>
> >
> > reg:
> > maxItems: 1
> > @@ -44,13 +50,11 @@ properties:
> > const: 64
> >
> > cache-level:
> > - const: 2
> > + enum: [2, 3]
> >
> > - cache-sets:
> > - enum: [1024, 2048]
> > + cache-sets: true
> >
> > - cache-size:
> > - enum: [131072, 262144, 524288, 1048576, 2097152]
> > + cache-size: true


See writing bindings. Widest constraints stay here.

Best regards,
Krzysztof