Re: [PATCH 0/4] ALSA: seq: ump: Fix Note On/Off and key pressure conversion
From: Takashi Iwai
Date: Mon Nov 16 2026 - 07:17:13 EST
On Mon, 16 Nov 2026 04:03:33 +0100,
HyeongJun An wrote:
>
> Hello Takashi,
>
> While extending seq-ump-test, I found three conversion bugs in
> seq_ump_convert.c. In each case the UMP core or the other sequencer
> path already does the right thing, and the fix follows it.
>
> Patches 1-3 are the fixes. They also apply to for-linus. Patch 4 adds
> the tests on top of seq-ump-test.c in for-next.
>
> Without patches 1-3, the new tests midi1_key_pressure,
> ump_midi1_to_midi2_note and ump_midi2_to_midi1_note fail and the other
> 25 pass. With them, all 28 pass.
>
> Prepared with Claude Code (Claude Opus 5.5). Tested on x86_64 under
> qemu, on sound/for-next.
>
> Best regards,
> HyeongJun An
>
> HyeongJun An (4):
> ALSA: seq: ump: Don't turn a zero key pressure into a Note Off
> ALSA: seq: ump: Convert a zero-velocity Note On to Note Off for MIDI
> 2.0
> ALSA: seq: ump: Keep a soft MIDI 2.0 Note On from becoming a Note Off
> selftests/alsa: Test the sequencer UMP Note On/Off conversion
Applied all four patches now to for-next branch. Thanks.
Takashi