Re: [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3
From: Krzysztof Kozlowski
Date: Mon Nov 16 2026 - 07:23:24 EST
On 16/11/2026 13:18, Nihal Kumar Gupta wrote:
>
>
> On 16-11-2026 17:39, Krzysztof Kozlowski wrote:
>>> Glymur has only three CSI2 PHYs, so there is no port@3 in the CAMSS
>>> binding.
>> ... so this was never working? Or was working but you change something?
>
> It was not used in-tree yet.
That's different question. You added ABI and that ABI could have been
used. Was the ABI ever correct in the first place?
> The existing example was wrong; this patch
> fixes it before adding the Glymur DTS.
>
> Glymur has three CSI2 PHY connections, so the logical CAMSS input ports
> are 0, 1 and 2.
Best regards,
Krzysztof