[PATCH] media: em28xx: Fix potential frontend leak on registration failure

From: Guangshuo Li

Date: Mon Nov 16 2026 - 09:10:53 EST


If registering the second frontend fails, fail_frontend1 detaches both
frontends without unregistering the already registered first frontend.

Move the label before its unregister call so the registration is
unwound before the frontend is detached.

This issue was found by our static analysis tool under development.

Fixes: f71095be6645 ("[media] em28xx: Multi Frontend (MFE) support")
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
drivers/media/usb/em28xx/em28xx-dvb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c
index 8482fc4045ea..88cf4705026d 100644
--- a/drivers/media/usb/em28xx/em28xx-dvb.c
+++ b/drivers/media/usb/em28xx/em28xx-dvb.c
@@ -1115,8 +1115,8 @@ static int em28xx_register_dvb(struct em28xx_dvb *dvb, struct module *module,
fail_dmx:
if (dvb->fe[1])
dvb_unregister_frontend(dvb->fe[1]);
- dvb_unregister_frontend(dvb->fe[0]);
fail_frontend1:
+ dvb_unregister_frontend(dvb->fe[0]);
if (dvb->fe[1])
dvb_frontend_detach(dvb->fe[1]);
fail_frontend0:

base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4