[PATCH] wifi: brcmfmac: Fix potential use-after-free on monitor registration failure
From: Guangshuo Li
Date: Mon Nov 16 2026 - 09:13:35 EST
A failed netdevice registration can invoke priv_destructor while
cfg80211_register_netdevice() still needs the wireless_dev embedded in
the vif. The caller also frees the vif on this error path.
Install the destructor only after registration succeeds, as done for
regular interfaces, and leave failed registration cleanup to the caller.
This issue was found by our static analysis tool under development.
Fixes: 20f2c5fa3af0 ("brcmfmac: add initial support for monitor mode")
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 46714d871260..aebc8f7b2a41 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -933,7 +933,6 @@ static struct wireless_dev *brcmf_mon_add_vif(struct wiphy *wiphy,
ndev->type = ARPHRD_IEEE80211_RADIOTAP;
ndev->ieee80211_ptr = &vif->wdev;
ndev->needs_free_netdev = true;
- ndev->priv_destructor = brcmf_cfg80211_free_vif;
SET_NETDEV_DEV(ndev, wiphy_dev(cfg->wiphy));
ifp = netdev_priv(ndev);
@@ -951,6 +950,7 @@ static struct wireless_dev *brcmf_mon_add_vif(struct wiphy *wiphy,
goto err_free_vif;
}
+ ndev->priv_destructor = brcmf_cfg80211_free_vif;
cfg->pub->mon_if = ifp;
return &vif->wdev;
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.43.0