Re: (subset) [PATCH 0/2] nvme: use the parsed offset for DH-CHAP secrets
From: Keith Busch
Date: Mon Nov 16 2026 - 11:18:50 EST
On Mon, 9 Nov 2026 22:59:14 +0800 (CST), shao.mingyin@xxxxxxxxxx wrote:
> Both the host and the target parse a DH-HMAC-CHAP secret with
> sscanf("DHHC-1:%hhd:...") and then skip a hardcoded ten characters to
> reach the key. The prefix is only nine characters when the hash
> identifier is one digit, so a short but accepted secret makes the key
> pointer point past the end of the string and the follow-up strlen() read
> past the allocation.
>
> [...]
Thanks, applied to nvme-7.4.
[2/2] nvmet-auth: store the DH-CHAP key offset instead of hardcoding it
commit: 62dae895f986f7459fea1deebd89a0bce76a886f
--
Keith Busch <kbusch@xxxxxxxxxx>