Re: [PATCH 0/2] remoteproc: k3: Recover a crashed remote core
From: Chrispine Tinega
Date: Mon Nov 16 2026 - 13:50:25 EST
Hi Francesco,
On Sun, Nov 15, 2026 at 10:11:01PM +0100, Francesco Valla wrote:
> An update on this. Recovery is definitley _not_ working on R5F remote
> cores in case of crash, because the reset action that is required from
> them to re-start correctly is in do_unprepare(), which the recovery
> action does not call (while sysfs does). This is of course out of the
> scope of your patch set, but has to be considered (maybe deserves a
> note in the commit message?).
Thank you for tracking that down. I agree it deserves a note. In v2
the commit message of patch 1 says that recovery cannot yet restart an
R5F, because the reset it needs is applied in unprepare(), which sysfs
stop calls and recovery does not. The R5F driver keeps recovery
disabled, so the series does not change what happens there: the core
moves to "crashed" and can be restarted through sysfs.
Making recovery work on the R5F, by doing that reset on the recovery
path too, seems like a separate series. I am happy to look at it after
this one.
v2 also drops the duplicate crash print, as you suggested. I have just
sent it:
https://lore.kernel.org/all/20261116184146.1897281-1-dev@xxxxxxxxxxxxxxxxxxx/
A Tested-by on v2 for patch 1 on the R5F would be very welcome.
Thanks,
Chrispine