Re: [PATCH] selftests: quote tr character classes in runner.sh
From: Ricardo B. Marlière (SUSE)
Date: Mon Nov 16 2026 - 13:55:48 EST
On Mon Nov 16, 2026 at 11:27 AM -03, Jori Koolstra (CIQ) wrote:
> The unquoted [:lower:] and [:upper:] arguments are subject to
> pathname expansion, so a single-character file such as 'l' or 'r'
> in the current directory would replace them and break the
> KSELFTEST_<TEST>_ARGS name sanitization. Quote them like the other
> tr invocations.
>
> Fixes: e005ff01bfdb ("selftests/kselftest/runner.sh: Pass optional command parameters in environment")
>
> Signed-off-by: Jori Koolstra (CIQ) <jkoolstra@xxxxxxxxx>
> ---
> tools/testing/selftests/kselftest/runner.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index 311811dc55a0..e81a35e607da 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -77,7 +77,7 @@ run_one()
> BASENAME_SANITIZED=$(echo "$BASENAME_TEST" | \
> $TR_CMD -d "[:blank:][:cntrl:]" | \
> $TR_CMD -c "[:alnum:]_" "_" | \
> - $TR_CMD [:lower:] [:upper:])
> + $TR_CMD "[:lower:]" "[:upper:]")
Reviewed-by: Ricardo B. Marlière (SUSE) <ricardo@xxxxxxxxxxxx>
> kselftest_cmd_args_ref="KSELFTEST_${BASENAME_SANITIZED}_ARGS"
> fi
>
>
> ---
> base-commit: 4d038dae9e5ba5b3fec87fad5b7bf3dc45523ca1
> change-id: 20261116-kselftest-runner-quote-tr-467bb5fe6dac
>
> Best regards,