Re: [PATCH] docs: submitting-patches: ask bug fixes for their user-visible impact
From: Andrew Morton
Date: Mon Nov 16 2026 - 14:35:09 EST
On Mon, 16 Nov 2026 14:14:36 -0500 Sasha Levin <sashal@xxxxxxxxxx> wrote:
> "Describe your changes" already asks for the user-visible impact of a
> change, but changelogs for fixes still tend to say what the code does,
> why that's wrong and what the patch changes, and stop there. Whoever
> has to decide if the fix needs backporting is left to work out what
> the bug does to a running system.
>
> Say what that means for a bug fix: describe the worst a user can see
> and what it takes to trigger it, say so if the bug was never seen to
> happen, and say so if it has no visible effect at all. Give the
> paragraph a label so people can be pointed at it.
>
> Coding assistants are told to commit a fix with a message that
> describes the problem and the solution. Add the user-visible impact to
> that list and point them at the section.
Thanks. Hopefully this will reduce my outbound nagmails.
Acked-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> +For a bug fix, this means saying what the bug does to a running system:
> +the worst that a user can see, and what it takes to trigger it. An
> +account of what the code does wrong is not a substitute, as it leaves
> +every reader to work the consequences out again. If the bug was found
> +by review or by a tool and has never been seen to happen, say so. If
> +it has no effect that a user could notice, say that too. Maintainers
> +and the people looking after stable trees decide from this whether the
> +fix needs to be backported.
However, I fear that in these times this isn't strong enough.
The question used to be "will this bug impact real-world people doing
real-world things".
That's an insufficient question to be asking now. An additional
question is "can this bug permit a sufficiently motivated, well funded
and LLM-using Bad Actor to cause problems".
Real-world people's real-world workloads don't use an LLM-written
exploit to set 16 CPUs hammering away at an LLM-detected kernel race
for an hour.
So those fantastically-hard-to-hit bugs have become things which we
(and those whom we serve) care about more than we used to.
Maybe this doc addresses that elsewhere, tl;dr ;)