Re: [PATCH v6 24/37] sched/deadline: Make a rebuild count a task in the root domain it runs in
From: sashiko-bot
Date: Mon Nov 16 2026 - 15:01:33 EST
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] sched/deadline: dl_task_rebuild_cpu() misaccounts
offline-migrated task
--
commit 9e9e921e040902e3cbd909c81dd80911851e51ce
Author: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
sched/deadline: Make a rebuild count a task in the root domain it runs in
This commit updates root-domain deadline bandwidth rebuilding to select the
CPU where a deadline task's bandwidth is counted based on the task's current
CPU, recorded dl_bw_cpu, active affinity mask, and cpuset, while skipping
tasks that have no active CPU available.
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index b43106a590256..c765a403014a2 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
[ ... ]
> @@ -3795,6 +3801,55 @@ static void dl_get_task_effective_cpus(struct task_struct *p, struct cpumask *cp
> cpuset_cpus_allowed_locked(p, cpus);
> }
>
> +/*
> + * Return a CPU of the root domain where a rebuild of the accounting should
> + * count the bandwidth of @p, or nr_cpu_ids if there is none.
> + *
> + * Prefer the CPU @p is on, if it is active and in the mask of @p. The
> + * task runs, or wakes up, in the root domain of that CPU. A mask can hold
> + * CPUs of two root domains: housekeeping CPUs and CPUs isolated by
> + * isolcpus="domain". When every CPU of a mask goes offline,
> + * select_fallback_rq() can widen it to both. It moves no bandwidth.
> + *
> + * Else prefer the CPU recorded with the bandwidth, if it is active and in
> + * the mask. It is in the root domain that admitted the bandwidth, or that
> + * its last move put it in. A task moved asleep is still on a CPU of the
> + * root domain it left, out of its mask. Else take the first active CPU of
> + * the mask, a housekeeping one if there is one. A task on isolated CPUs
> + * that all went offline can have no active CPU at all.
> + */
> +static unsigned int dl_task_rebuild_cpu(struct task_struct *p)
> +{
> + struct cpumask *msk = this_cpu_cpumask_var_ptr(local_cpu_mask_dl);
> + int recorded = p->dl.dl_bw_cpu;
> + unsigned int cpu;
> +
> + /*
> + * Look at the mask of the task first. A change of the cpusets sets
> + * the mask of each task before its rebuild. The housekeeping mask
> + * that dl_get_task_effective_cpus() reads is updated after it. If no
> + * CPU of the mask is active, take the CPU recorded if it is active.
> + * dl_task_offline_migration() moved the task there, or an earlier
> + * rebuild counted it there. Else ask the cpuset.
> + */
> + cpumask_and(msk, &p->cpus_mask, cpu_active_mask);
> + cpu = task_cpu(p);
> + if (cpumask_test_cpu(cpu, msk))
> + return cpu;
> + if (cpumask_empty(msk)) {
> + if (recorded >= 0 && cpu_active(recorded))
> + return recorded;
> + dl_get_task_effective_cpus(p, msk);
> + cpumask_and(msk, msk, cpu_active_mask);
> + } else if (recorded >= 0 && cpumask_test_cpu(recorded, msk)) {
> + return recorded;
> + }
> + cpu = cpumask_first_and(msk, housekeeping_cpumask(HK_TYPE_DOMAIN_BOOT));
> + if (cpu < nr_cpu_ids)
> + return cpu;
> + return cpumask_first(msk);
> +}
[Severity: Medium]
Can dl_task_rebuild_cpu() count a task migrated by
dl_task_offline_migration() in the wrong root domain once a CPU in
p->cpus_mask comes back online?
When admission control is disabled and all CPUs in p->cpus_ptr are offline,
dl_task_offline_migration() falls back to cpumask_any(cpu_active_mask) and
moves a throttled task's bandwidth and runqueue placement to that fallback
CPU without changing p->cpus_mask:
kernel/sched/deadline.c:dl_task_offline_migration() {
...
cpu = cpumask_any_and(cpu_active_mask, p->cpus_ptr);
if (cpu >= nr_cpu_ids) {
...
cpu = cpumask_any(cpu_active_mask);
}
later_rq = cpu_rq(cpu);
...
}
If p was pinned to a single offline CPU (p->nr_cpus_allowed == 1), it is not
pushable and continues running and replenishing on the fallback CPU even
after its original CPU comes back online. During the rebuild triggered by
that cpu_up(), msk (&p->cpus_mask & cpu_active_mask) is no longer empty, and
neither task_cpu(p) nor recorded (p->dl.dl_bw_cpu) is in msk.
dl_task_rebuild_cpu() then returns a CPU from msk rather than task_cpu(p),
accounting the bandwidth in the root domain of p->cpus_mask instead of the
root domain where the task is still queued and running.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116190549.230119-1-mathieu.desnoyers@xxxxxxxxxxxx?part=24