Re: [PATCH v5] PCI/PME: Resume Catlow Lake Root Ports on PME with PME Status clear
From: Kuppuswamy Sathyanarayanan
Date: Mon Nov 16 2026 - 16:45:42 EST
Hi Bjorn,
Please let me know your comments.
On 11/16/26 08:43, Lukas Wunner wrote:
> On Tue, Nov 03, 2026 at 11:31:36AM -0800, Kuppuswamy Sathyanarayanan wrote:
>> Intel Catlow Lake PCH Root Ports do not set PME Status in the Root
>> Status register when they generate a PME for their own hotplug event.
>> The PME interrupt itself is delivered. PMEs from devices below the Root
>> Port are reported correctly.
>>
>> PME and hotplug share the same interrupt. When a hotplug Root Port
>> runtime suspends to D3hot, pciehp disables hotplug interrupts and relies
>> on PME to resume the Port. On a hot-add the Port signals PME, but Root
>> Status stays clear. pcie_pme_irq() then returns IRQ_NONE. pciehp_isr()
>> also returns IRQ_NONE because hotplug interrupts are disabled. The Port
>> stays in D3hot and the new device is never enumerated.
>>
>> Mark the affected Root Ports with a new PCI_DEV_FLAGS_PME_UNRELIABLE
>> flag. If such a Port interrupts while not in D0 and PME Status is
>> clear, pcie_pme_irq() resumes the Port. pciehp re-enables hotplug
>> interrupts on runtime resume, and pciehp_check_presence() finds the new
>> device. pciehp itself is unchanged.
> [...]
>> Suggested-by: Lukas Wunner <lukas@xxxxxxxxx>
>> Link: https://lore.kernel.org/linux-pci/ara-_IPXV_i90if1@xxxxxxxxx/
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer