Re: [PATCH v3 RESEND] ufs: sysfs: Add WB partial flush mode support

From: Daniel Lee

Date: Mon Nov 16 2026 - 17:07:42 EST


On Sun, Nov 15, 2026 at 7:02 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 11/15/26 6:05 PM, Daniel Lee wrote:
> > +What:
> /sys/bus/platform/drivers/ufshcd/*/attributes/wb_partial_flush_mode
> > +What: /sys/bus/platform/devices/*.ufs/attributes/wb_partial_flush_mode
> > +Date: June 2026
> > +Contact: Daniel Lee <chullee@xxxxxxxxxx>
> > +Description: This entry controls Extended WriteBooster partial flush
> modes.
> > +
> > + ======== ==============================
> > + "none" No partial flush
> > + "fifo" FIFO mode
> > + "pinned" Pinned mode
> > + ======== ==============================
> > +
> > + The attribute is read-write.
>
> Please update the Date: field across the new ABI entries (June 2026 has
> passed).
>
> Also, please drop the quotes around "none", "fifo", and "pinned" to match
> the other string attributes in this file (such as wb_resize_hint,
> wb_resize_status, and hid/state), since literal quotes are neither emitted
> nor accepted.
>
> > +Description: This entry configures the maximum size in Allocation
> Units reserved for the
> > + WriteBooster FIFO Buffer size.
> > + The attribute is read-write.
> > +
> > +What: /sys/bus/platform/drivers/ufshcd/*/attributes/wb_cur_fifo_size
> > +What: /sys/bus/platform/devices/*.ufs/attributes/wb_cur_fifo_size
> > +Date: June 2026
> > +Contact: Daniel Lee <chullee@xxxxxxxxxx>
> > +Description: This entry shows the current size in Allocation Units
> of the WriteBooster FIFO
> > + Buffer size.
> > + The attribute is read only.
>
> Minor: please drop the redundant trailing "size" in "WriteBooster FIFO
> Buffer size" in both descriptions above.
>
> > +What: /sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_avail_pct
> > +What: /sys/bus/platform/devices/*.ufs/attributes/wb_pinned_avail_pct
> > +Date: June 2026
> > +Contact: Daniel Lee <chullee@xxxxxxxxxx>
> > +Description: This entry shows the percentage of available space
> remaining in the
> > + Pinned WriteBooster buffer.
> > + The attribute is read-only.
>
> Per JESD220G Table 14.28 (IDN 43h,
> bPinnedWriteBoosterBufferAvailablePercentage),
> this value is reported in 10% granularity (00h: 0%, 01h-09h: 10%-90%,
> 0Ah: 100%), not 0-100%. Please document the 10% granularity so userspace
> does not misinterpret 0x0000000A as 10%.
>
> > +What:
> /sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_cumulative_write_size
> > +What:
> /sys/bus/platform/devices/*.ufs/attributes/wb_pinned_cumulative_write_size
> > +Date: June 2026
> > +Contact: Daniel Lee <chullee@xxxxxxxxxx>
> > +Description: This entry shows the total cumulative size of data
> written to the
> > + Pinned WriteBooster buffer.
> > + The attribute is read-only.
>
> Please state the unit here: per JESD220G Table 14.28 (IDN 44h), this value
> is in units of 10 MB (and saturates at 0xFFFFFFFF).
>
> > +What: /sys/bus/platform/drivers/ufshcd/*/flags/wb_unpin_enable
> > +What: /sys/bus/platform/devices/*.ufs/flags/wb_unpin_enable
> > +Date: June 2026
> > +Contact: Daniel Lee <chullee@xxxxxxxxxx>
> > +Description: This entry controls the Pinned WriteBooster unpin
> enable flag (fUnpinEn).
> > +
> > + ======
> ==============================================================
> > + 0 Unpin Disable: pinned data is not flushed by WriteBooster
> > + Buffer flush operation.
> > + 1 Unpin Enable: pinned data is flushed by WriteBooster
> > + Buffer flush operation.
> > + ======
> ==============================================================
> > +
> > + The attribute is read-write.
>
> ufs_sysfs_flag_show() emits "false" or "true" via str_true_false(flag),
> not 0 or 1, while ufs_sysfs_flag_store() accepts any kstrtobool() value
> (0/1, false/true, n/y, off/on). Please update this description so it
> accurately reflects what reading returns and what writing accepts.
>
> > static inline bool ufshcd_is_wb_flags(enum flag_idn idn)
> > {
> > - return idn >= QUERY_FLAG_IDN_WB_EN &&
> > - idn <= QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8;
> > + return (idn >= QUERY_FLAG_IDN_WB_EN &&
> > + idn <= QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8) ||
> > + idn == QUERY_FLAG_IDN_WB_UNPIN_EN;
> > +}
>
> Per JESD220G Table 14.26, fUnpinEn (13h) has Type "D" (device-level,
> addressed with INDEX = 00h and SELECTOR = 00h per Note 1), unlike flags
> 0Eh-10h which are "A/LU/0 or D" (Note 4). Including
> QUERY_FLAG_IDN_WB_UNPIN_EN here will send a non-zero INDEX when
> WriteBooster uses an LU-dedicated buffer on a non-zero LUN. Please leave
> ufshcd_is_wb_flags() unchanged.

Thanks for pointing this out.

By the way, the name ufshcd_is_wb_flags() is a bit confusing with the
addition of
Type "D" WB flags and attributes, so it might be good to rename it to
ufshcd_is_lu_wb_flag().

For v4, I will keep the exisiting names as requested.

>
> > static inline bool ufshcd_is_wb_attrs(enum attr_idn idn)
> > {
> > - return idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
> > - idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE;
> > + return (idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
> > + idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE) ||
> > + (idn >= QUERY_ATTR_IDN_WB_PFM &&
> > + idn <= QUERY_ATTR_IDN_NON_PINNED_WB_MIN_SIZE);
> > }
>
> Same issue here. Per JESD220G Table 14.28:
> - 3Fh (bWriteBoosterBufferPartialFlushMode),
> 42h (dPinnedWriteBoosterBufferCurrentAllocUnits),
> 43h (bPinnedWriteBoosterBufferAvailablePercentage), and
> 44h (dPinnedWriteBoosterCummulativeWrittenSize) are Type "D" (INDEX =
> 00h).
> - Only 40h, 41h, 45h, and 46h are "A/LU/0 or D" (Note 15).
>
> Please restrict ufshcd_is_wb_attrs() to the LU-indexed attributes
> (1Ch-1Fh, 40h-41h, and 45h-46h).
>
> > +static ssize_t ufs_sysfs_attr_store(struct device *dev,
> > + struct device_attribute *attr, const char *buf, size_t count,
> > + enum attr_idn idn)
> > +{
> > + struct ufs_hba *hba = dev_get_drvdata(dev);
> > + u8 index = 0;
> > + u32 value;
> > + int ret;
> > +
> > + if (kstrtou32(buf, 0, &value))
> > + return -EINVAL;
>
> Since ufs_sysfs_attr_show() supports 64-bit attributes via
> ufshcd_is_qword_attr(idn), please either support ufshcd_is_qword_attr(idn)
> here as well or guard against it (e.g. WARN_ON_ONCE) so a future
> UFS_ATTRIBUTE_RW() user for a 64-bit attribute cannot silently issue a
> 32-bit query.
>
> > + ufshcd_rpm_get_sync(hba);
> > + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> > + QUERY_ATTR_IDN_WB_PFM, ufshcd_wb_get_query_index(hba), 0, &value);
> > + ufshcd_rpm_put_sync(hba);
>
> Since QUERY_ATTR_IDN_WB_PFM (3Fh) is Type "D" per JESD220G Table 14.28,
> please pass 0 instead of ufshcd_wb_get_query_index(hba) here and in
> wb_partial_flush_mode_store().
>
> Also, unlike wb_resize_hint / wb_resize_status / wb_resize_enable, none of
> the new entries check hba->dev_info.ext_wb_sup
> (wExtendedWriteBoosterSupport:
> BIT(1) for FIFO Partial Flush Mode and BIT(2) for Pinned Partial Flush
> Mode per JESD220G Table 14.4, plus hba->dev_info.b_presrv_uspc_en for
> Pinned mode per Section 13.4.18.7). Should we define those capability bits
> in include/ufs/ufs.h and check them (returning -EOPNOTSUPP or hiding
> unsupported attributes via .is_visible) rather than waking the device and
> issuing unsupported queries on devices without these features?

Agreed. I will define them and return -EOPNOTSUPP when unsupported (matching
wb_resize_hint / wb_resize_status / wb_resize_enable).

Thanks,
Daniel

>
> > + QUERY_ATTR_IDN_PINNED_WB_CUMMULATIVE_WS = 0x44,
>
> Please spell this CUMULATIVE (single 'M'), matching the sysfs attribute
> name wb_pinned_cumulative_write_size and JESD220G Section 13.4.18.7.2.
>
> Thanks,
>
> Bart.