RE: [PATCH rtw-next v3] wifi: rtw89: acpi: check for _DSM function support before evaluating it

From: Ping-Ke Shih

Date: Mon Nov 16 2026 - 20:33:42 EST


Rosen Penev <rosenp@xxxxxxxxx> wrote:
> When the WiFi device has no ACPI companion, or the firmware does not
> implement a given rtw89 _DSM function, rtw89_acpi_evaluate_dsm() calls
> acpi_evaluate_dsm() anyway. ACPI core then warns on every probe:
>
> ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:10 (0x1001)
> ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:6 (0x1001)
>
> Here the handle is NULL, and acpi_evaluate_object() returns
> AE_BAD_PARAMETER. All callers already treat failure as "no policy
> provided by the platform", so this is only noise.
>
> Bail out early when there is no ACPI handle,
>
> Seen on an RTL8852BE in a desktop PCIe slot.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>