RE: [PATCH rtw-next v2 4/5] wifi: rtlwifi: usb: move the radiotap headroom size to usb.h
From: Ping-Ke Shih
Date: Mon Nov 16 2026 - 20:51:32 EST
Ho Jie Feng <hjf3108@xxxxxxxxx> wrote:
> Let drivers use the same define to add headroom for the frames
> split out of aggregated transfers.
>
> Move __RADIO_TAP_SIZE_RSV to usb.h as RTL_RADIO_TAP_SIZE_RSV
> so chip specific code can use it.
>
> Signed-off-by: Ho Jie Feng <hjf3108@xxxxxxxxx>
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Carry my Acked-by to v3 with a nit below.
[...]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.h
> b/drivers/net/wireless/realtek/rtlwifi/usb.h
> index b873bbc9c4..329b734ca1 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/usb.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/usb.h
> @@ -7,6 +7,7 @@
> #include <linux/skbuff.h>
>
> #define RTL_RX_DESC_SIZE 24
> +#define RTL_RADIO_TAP_SIZE_RSV 32
nit: prefer to align the column of number.
Though I'm not fan of <tabs + space> alignment, it is there already.
Just let it look comfortable.
>
> #define RTL_USB_DEVICE(vend, prod, cfg) \
> .match_flags = USB_DEVICE_ID_MATCH_DEVICE, \
> --
> 2.53.0