Re: [PATCH net-next v2 3/4] net: phy: marvell: factor out EEE errata initialization
From: Andrew Lunn
Date: Mon Nov 16 2026 - 21:04:36 EST
On Mon, Nov 16, 2026 at 04:27:03PM +0100, Paul Louvel wrote:
> The 88E151x EEE errata sequence writes four register pairs on page 0xFF.
> Using phy_write() for each access takes and releases the MDIO bus lock
> every time, and returning early on error leaves the PHY on the errata
> page.
>
> Move the sequence into m88e1510_eee_errata() and use phy_select_page()
> and phy_restore_page().
> This reduces the number of bus lock/unlock cycles and restores the
> previous page if one of the errata writes fails.
>
> Signed-off-by: Paul Louvel (Schneider Electric) <paul.louvel@xxxxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew