Re: [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file

From: SJ Park

Date: Mon Nov 16 2026 - 21:11:13 EST


On Mon, 16 Nov 2026 19:10:05 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@xxxxxxxxxx> wrote:

> From: Mattathias Pinchover <mattathias.pinchover@xxxxxxxx>
>
> Introduce a new DAMON sysfs interface file for exposing the newly added
> DAMOS stat, sz_ops_filter_passed_last. The file has the same
> name as the stat and is placed under the DAMOS stats directory. Like
> other stats files, it is updated when the stats are refreshed via
> refresh_ms or the update_schemes_stats command.

Looks good to me.

>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Mattathias Pinchover <mattathias.pinchover@xxxxxxxx>
> ---
> mm/damon/sysfs-schemes.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
[...]
> @@ -485,6 +495,10 @@ static struct kobj_attribute damon_sysfs_stats_sz_applied_attr =
> static struct kobj_attribute damon_sysfs_stats_sz_ops_filter_passed_attr =
> __ATTR_RO_MODE(sz_ops_filter_passed, 0400);
>
> +static struct kobj_attribute
> +damon_sysfs_stats_sz_ops_filter_passed_last_attr =

Seems the above two lines could be in a single line without breaking the 80
characters per line limit. Could we just do so and save one line?

Other than that,

Reviewed-by: SJ Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]