RE: [PATCH rtw-next 1/6] wifi: rtlwifi: use struct ieee80211_pspoll for the PS Poll reserved page
From: Ping-Ke Shih
Date: Mon Nov 16 2026 - 21:19:38 EST
Rishik Yechuri <epicrishik@xxxxxxxxx> wrote:
> The reserved page builders fill in the PS Poll template with the
> SET_80211_PS_POLL_* macros from base.h, which write at fixed byte
> offsets into a u8 buffer. The AID macro stores a host order u16, so
> the frame is only correct on a little endian machine.
>
> Point at the template with struct ieee80211_pspoll from
> <linux/ieee80211.h> instead.
No need this sentence. It is obvious.
> Its aid member is __le16, so the AID goes
> through cpu_to_le16() and sparse can check it. The two addresses are
> copied with ether_addr_copy() on the struct members. Remove the three
> macros.
>
> On little endian systems the bytes written are the same as before.
>
> Signed-off-by: Rishik Yechuri <rishik.yechuri.code@xxxxxxxxx>
Not match the From: field
> Assisted-by: Claude:claude-fable-5-1
No need Assisted-by.
Please check the result of patchwork:
https://patchwork.kernel.org/project/linux-wireless/list/?series=1207558
[...]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> index 9a9f9e14f472..cda9388388ab 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> @@ -545,7 +545,7 @@ void rtl88e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
> u8 u1rsvdpageloc[5] = { 0 };
> bool b_dlok = false;
> u8 *beacon;
> - u8 *p_pspoll;
> + struct ieee80211_pspoll *p_pspoll;
reverse x'mas tree (apply to whole patch)
> u8 *nullfunc;
> u8 *p_probersp;
>