RE: [PATCH rtw-next 2/6] wifi: rtlwifi: use struct ieee80211_hdr for the reserved page headers
From: Ping-Ke Shih
Date: Mon Nov 16 2026 - 21:25:04 EST
Rishik Yechuri <epicrishik@xxxxxxxxx> wrote:
> The reserved page builders also patch the addresses of the beacon, null
> data, probe response, QoS null data, BT QoS null data and ARP response
> templates with SET_80211_HDR_ADDRESS1(), SET_80211_HDR_ADDRESS2() and
> SET_80211_HDR_ADDRESS3() from base.h. These add a hard coded byte
> offset to a u8 pointer and copy the six bytes one at a time through
> the CP_MACADDR() macro in wifi.h.
>
> struct ieee80211_hdr from <linux/ieee80211.h> has the addr1, addr2 and
> addr3 members at the same offsets.
No need this sentence. It is obvious.
Please reword commit messages generated by LLM across whole patchset.
> Point at each template with that
> struct and copy the addresses with ether_addr_copy() on the members.
> Then remove the three macros, CP_MACADDR() and the FRAME_OFFSET_*
> constants, which have no other users.
>
> No functional change intended.
>
> Signed-off-by: Rishik Yechuri <rishik.yechuri.code@xxxxxxxxx>
> Assisted-by: Claude:claude-fable-5-1
[...]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> index cda9388388ab..da9ef7cab2fb 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> @@ -544,18 +544,18 @@ void rtl88e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
> bool rtstatus;
> u8 u1rsvdpageloc[5] = { 0 };
> bool b_dlok = false;
> - u8 *beacon;
> + struct ieee80211_hdr *beacon;
> struct ieee80211_pspoll *p_pspoll;
> - u8 *nullfunc;
> - u8 *p_probersp;
> + struct ieee80211_hdr *nullfunc;
> + struct ieee80211_hdr *p_probersp;
reverse x'mas tree