Re: [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat

From: SJ Park

Date: Mon Nov 16 2026 - 21:42:48 EST


Hello Mattathias,

On Mon, 16 Nov 2026 19:10:03 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@xxxxxxxxxx> wrote:

> DAMOS stat sz_ops_filter_passed shows the total bytes that passed
> operations layer-handled DAMOS filters, accumulated from the beginning
> of the scheme's execution. Users who want the amount for only the
> latest apply interval, e.g., the size of a workload's anonymous memory
> that is cold as of now, have to keep the previous value in user space
> and compute the difference. To know how many apply intervals a
> difference covers, they have to rely on nr_snapshots. But nr_snapshots
> is increased once per target per apply interval, so the computation is
> complicated for contexts having multiple targets.
>
> This series introduces a new DAMOS stat, sz_ops_filter_passed_last. It
> shows the amount of sz_ops_filter_passed increase in the last apply
> interval of the scheme. It is updated at the end of each apply
> interval, and kept unchanged until the next apply interval is
> completed. Like the other DAMOS stats, it is exposed under the stats/
> directory of the scheme in the DAMON sysfs interface, and refreshed
> together with the other stats when refresh_ms expires or
> update_schemes_stats is written.

Thank you for this series!

>
> Patches sequence
> ================
>
> Patch 1 introduces the stat to the DAMON core. Patch 2 exposes it via
> the DAMON sysfs interface. Patch 3 adds a kunit test. Patches 4-6
> update the design, usage, and ABI documents, respectively.

I left a few comments. Maybe patch 3 needs a change that might deserve
respinning. Could you please address all the comments?

>
> Tests
> =====
[...]
> Tool use
> ========
>
> Claude (Anthropic) assisted with the code, kunit test, documents, and
> changelogs of this series, as noted by the Assisted-by: tags. I
> reviewed all of it and ran the tests listed above.

Knowing what tests are already passed and what tool is used is helpful for
reviewing. Thank you for sharing those, Mattathias. FWIW, Assisted-by: tag is
no more required [1]. I don't mind having it, though.

[1] 1e035297ffda ("docs: remove Assisted-by references")



Thanks,
SJ

[...]