[PATCH] HID: gembird: bound the report descriptor check by the pattern size

From: Shirong Zhao

Date: Mon Nov 16 2026 - 23:13:45 EST


gembird_report_fixup() compares the report descriptor against the
26-byte faulty pattern starting at offset GEMBIRD_START_FAULTY_RDESC
(8), so memcmp() reads rdesc[8,34). The guard only requires
*rsize >= 31, so a device reporting a 31-33 byte descriptor triggers a
1-3 byte heap out-of-bounds read.

If the adjacent heap bytes happen to match the tail of the pattern,
the fixup body then runs and memcpy()s the fixed pattern at offset 8
into a buffer sized *rsize + delta_size, overflowing it as well.

Any descriptor that really contains the faulty pattern is at least 34
bytes long, so requiring GEMBIRD_START_FAULTY_RDESC +
sizeof(faulty pattern) does not change behaviour for real hardware.

Fixes: 931830aa5c25 ("HID: gembird: add new driver to fix Gembird JPD-DualForce 2")
Signed-off-by: Shirong Zhao <shxzhaosr@xxxxxxx>
---
drivers/hid/hid-gembird.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-gembird.c b/drivers/hid/hid-gembird.c
index 20a8de7..ae56ba9 100644
--- a/drivers/hid/hid-gembird.c
+++ b/drivers/hid/hid-gembird.c
@@ -66,9 +66,11 @@ static const __u8 *gembird_report_fixup(struct hid_device *hdev, __u8 *rdesc,
sizeof(gembird_jpd_faulty_rdesc);
size_t new_size = *rsize + delta_size;

- if (*rsize >= 31 && !memcmp(&rdesc[GEMBIRD_START_FAULTY_RDESC],
- gembird_jpd_faulty_rdesc,
- sizeof(gembird_jpd_faulty_rdesc))) {
+ if (*rsize >= GEMBIRD_START_FAULTY_RDESC +
+ sizeof(gembird_jpd_faulty_rdesc) &&
+ !memcmp(&rdesc[GEMBIRD_START_FAULTY_RDESC],
+ gembird_jpd_faulty_rdesc,
+ sizeof(gembird_jpd_faulty_rdesc))) {
new_rdesc = devm_kzalloc(&hdev->dev, new_size, GFP_KERNEL);
if (new_rdesc == NULL)
return rdesc;