[PATCH] perf parse-events: free partially copied terms if term cloning fails
From: Gu Bin
Date: Tue Nov 17 2026 - 04:56:23 EST
parse_events_terms__copy() clones the terms of src into dest one by
one and stops as soon as parse_events_term__clone() fails, leaving the
terms cloned so far queued on dest->terms. Both callers,
parse_events_add_pmu() and parse_events_multi_pmu_add(), return on
that error without freeing the local parsed_terms, so the partially
copied terms and their strings are leaked.
Free the local terms with parse_events_terms__exit() before
returning, as both functions already do on their later error paths.
Fixes: 0d3f0e6f94ef ("perf parse-events: Introduce 'struct parse_events_terms'")
Signed-off-by: Gu Bin <gubin@xxxxxxxxxxxxxxxxxxxx>
---
tools/perf/util/parse-events.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index f3ba70d4f76b..8ab02a2fe1c3 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1539,8 +1539,10 @@ static int parse_events_add_pmu(struct parse_events_state *parse_state,
if (const_parsed_terms) {
int ret = parse_events_terms__copy(const_parsed_terms, &parsed_terms);
- if (ret)
+ if (ret) {
+ parse_events_terms__exit(&parsed_terms);
return ret;
+ }
}
fix_raw(&parsed_terms, pmu);
@@ -1642,8 +1644,10 @@ int parse_events_multi_pmu_add(struct parse_events_state *parse_state,
if (const_parsed_terms) {
int ret = parse_events_terms__copy(const_parsed_terms, &parsed_terms);
- if (ret)
+ if (ret) {
+ parse_events_terms__exit(&parsed_terms);
return ret;
+ }
}
config = strdup(event_name);
--
2.50.1.windows.1