Re: [PATCH] usb: typec: stusb160x: disable the interrupt before tearing down
From: Heikki Krogerus
Date: Tue Nov 17 2026 - 05:22:35 EST
On Thu, Nov 12, 2026 at 01:56:20AM -0500, Myeonghun Pak wrote:
> The devm-managed IRQ remains active while stusb160x_remove() tears down
> the partner, VBUS, role switch and Type-C port. An attach or detach event
> can race with partner removal or access the port and role switch after
> they are released.
>
> Disable and synchronize the IRQ at the start of remove(), before any of
> these resources are torn down.
>
> Found by a static analysis tool under development.
> Not tested on hardware.
The same question here. Why still use the devm_* to request the irq?
Thanks,
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Cc: stable@xxxxxxxxxxxxxxx
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> ---
>
> drivers/usb/typec/stusb160x.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index a2ec0565bd85..ec2f4d7f7ed3 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -801,6 +801,9 @@ static void stusb160x_remove(struct i2c_client *client)
> {
> struct stusb160x *chip = i2c_get_clientdata(client);
>
> + if (client->irq)
> + disable_irq(client->irq);
> +
> if (chip->partner) {
> typec_unregister_partner(chip->partner);
> chip->partner = NULL;
>
> base-commit: 630059a5a632377b9b7b487baccde92b7ae1dd47
> --
> 2.43.0
--
heikki