[PATCH] ALSA: core: Validate card indices in lookup helpers

From: Sreeraj S Kurup

Date: Tue Nov 17 2026 - 05:43:03 EST


Ensure card indices are within the valid range before accessing
the card array or lock bitmap in snd_card_ref() and
snd_card_locked().

This prevents out-of-range indices from causing invalid memory
accesses in these lookup helpers. It also protects against
invalid indices passed by existing or future callers.

Return NULL from snd_card_ref() and 0 from snd_card_locked()
when an invalid card index is supplied.

Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@xxxxxxxxx>
---
sound/core/init.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/sound/core/init.c b/sound/core/init.c
index d518cb838777..f79b63c69a49 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -384,6 +384,9 @@ struct snd_card *snd_card_ref(int idx)
{
struct snd_card *card;

+ if (idx < 0 || idx >= SNDRV_CARDS)
+ return NULL;
+
guard(mutex)(&snd_card_mutex);
card = snd_cards[idx];
if (card)
@@ -395,6 +398,9 @@ EXPORT_SYMBOL_GPL(snd_card_ref);
/* return non-zero if a card is already locked */
int snd_card_locked(int card)
{
+ if (card < 0 || card >= SNDRV_CARDS)
+ return 0;
+
guard(mutex)(&snd_card_mutex);
return test_bit(card, snd_cards_lock);
}
--
2.55.0