Re: [PATCH v3] reset: core: honour optional resets when the GPIO fallback returns -ENOENT

From: Philipp Zabel

Date: Tue Nov 17 2026 - 06:11:45 EST


On Di, 2026-11-17 at 19:08 +0800, Yang Siyuan wrote:
> __fwnode_reset_control_get() honours RESET_CONTROL_FLAGS_BIT_OPTIONAL by
> returning NULL when the requested reset is not described in the device
> tree. The reset-gpio fallback breaks this: when
> __reset_add_reset_gpio_device() fails with -ENOENT, the error is returned
> even for an optional reset.
>
> This is reachable on Allwinner SoCs, whose pinctrl uses three-cell GPIO
> specifiers. The reset-gpio fallback only supports two cells, so it
> returns -ENOENT and a consumer asking for an optional reset fails to
> probe instead of falling back to its own GPIO handling. mmc-pwrseq-simple
> on the Anbernic RG35XX family hits this: its wifi_pwrseq node has
> reset-gpios but no resets, so the SDIO WiFi adapter never probes.
>
> Return NULL only for -ENOENT when the reset was requested as optional.
> A reset that is described but cannot be used is still an error, so
> -EPROBE_DEFER and all other failures are propagated.
>
> Signed-off-by: Yang Siyuan <hsyysy@xxxxxxx>

Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

regards
Philipp