Re: [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency
From: Geert Uytterhoeven
Date: Tue Nov 17 2026 - 06:13:48 EST
Hi Arnd,
On Thu, 12 Nov 2026 at 15:14, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The dependency on CONFIG_POWER_SEQUENCING is ignored when
> ARCH_RZG2L is enabled, and this can lead to a build failure
> when power sequencing is in a loadable module but the
> reset driver is built-in:
>
> drivers/reset/reset-rzg2l-usbphy-ctrl.o: in function `rzg2l_usbphy_ctrl_suspend':
> reset-rzg2l-usbphy-ctrl.c:(.text+0x21c): undefined reference to `pwrseq_disable'
>
> Change the dependency to always depend on the power sequencing
> interface.
>
> Fixes: 5ca65d048910 ("reset: rzg2l-usbphy-ctrl: Add RZ/G3L support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks for your patch, which is now commit eac3b292a26e2210
("reset: rzg2l-usbphy-ctrl: add power sequencing dependency") in
reset/reset/next.
This breaks USB on e.g. RZ/Five when POWER_SEQUENCING is not
enabled (e.g. rzfive_defconfig in renesas-devel), as supplier
/soc/usbphy-ctrl@11c40000/regulator-vbus no longer has a driver.
I guess the same issue can be seen on other RZ/G2L variants.
Reverting this commit fixes the issue.
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -279,7 +279,8 @@ config RESET_RASPBERRYPI
>
> config RESET_RZG2L_USBPHY_CTRL
> tristate "Renesas RZ/G2L USBPHY control driver"
> - depends on ARCH_RZG2L || (COMPILE_TEST && POWER_SEQUENCING)
AFAIU, the power sequencing part is optional, and only needed on
RZ/G3L (SYSC_R9A08G046 selects POWER_SEQUENCING).
The fact that compile-testing required POWER_SEQUENCING before was
already a red flag...
> + depends on ARCH_RZG2L || COMPILE_TEST
> + depends on POWER_SEQUENCING
"depends on POWER_SEQUENCING || !POWER_SEQUENCING"?
I have sent a fix
https://lore.kernel.org/0b1c87b3173a789f6227f13658e4befdac8e47e0.1794913893.git.geert+renesas@xxxxxxxxx
> select MFD_SYSCON
> help
> Support for USBPHY Control found on RZ/G2L family. It mainly
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds