Re: [PATCH 2/2] io_uring/net: Add bundle support for multishot recvmsg
From: Clément Léger
Date: Tue Nov 17 2026 - 07:06:54 EST
On 11/17/26 03:45, Jens Axboe wrote:
> On 11/16/26 4:17 AM, Clément Léger wrote:IORING_RECVSEND_BUNDLE was disabled for IORING_OP_RECVMSG because the
envelope and control-message sizing was not implemented. Enable
bundled multishot recvmsg by reserving its metadata in the first buffer
and accounting for payload spread across the selected buffer run.
Patch 1 is fine (though both need rebasing against for-7.5/io_uring),
but a few notes on this one:
Hi Jens,
Thanks for the review.
1) This changes behavior for UDP, which has no inq as per a comment
in here as well, now it asks for MAX_RW_LEN.
Agreed, technically, it doesn't change the existing behavior for plain recv but differ for the new recvmsg + bundles support. I'll try to match what's done for plain recv with max_len == 0 and use mshot_len with bundles.
2) Why not support incremental buffer rings?
I deliberately left it since it required more wiring/modifications. I can add it in the next version though.
And the usual, do you have a liburing test and man page updates as
well?
Yes indeed, I have liburing tests, just didn't to send them right away. I'm missing the man page update though. I'll add it for V2
A minor note is that the commenting is a bit excessive... I'd prune
that for v2.
I'd usually remove them but they mostly seemed useful to me. I'll prune that.
Thanks,
Clément